IBX-1021: Fixed database DSN string generation #44
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
|
Ping @ezsystems/php-dev-team since I can't ask for review directly |
|
@kmadejski what are the steps to reproduce here? |
I think an attempt to use DFS on Platform.sh would lead to this problem. I found it accidentally when I was about to reuse this piece of code for a different use case, hence no steps to reproduce in the ticket. |
There was a problem hiding this comment.
To be honest I have "no concrete feelings" on this change.
I tried the default DFS/NFS setup (https://doc.ibexa.co/en/3.3/guide/clustering/#configuring-the-dfs-io-handler) with Ibexa Commerce 3.3.8 on platform.sh on a development instance.
Without this change images and videos were properly stored in a separate dfs database in the ezdfsfile table. (The files were also stored in the dfsdata directory on p.sh.)
With this change images and videos were also stored in the separate database.
Without more information on your use case I cannot tell if this is necessary. 😄
|
@micszo thanks for testing. It is a kind of mystery to me then, as this fragment of code is supposed to generate DSN used later on by doctrine for establishing a connection to the DFS database. I think it is clear to all reviewers that the previous version is clearly wrong. Another question would be: why and how this is overwritten on the cloud so it works fine? |
|
I need to investigate this deeper then, expected different outcome. |
2.3TODO: